Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Update nfs to lib 4 and client-go w GetReference fix #1208

Merged
merged 1 commit into from Aug 16, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 16, 2019

step 1 of resolving failing alpha suite kubernetes/kubernetes#81403

Thanks to go modules + submodules, we can now update provisioners 1 by 1 :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2019
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 16, 2019

/cc @jsafrane
I'll probably need to self-lgtm.

@wongma7 wongma7 force-pushed the nfs-getreference branch 5 times, most recently from 8e79b29 to 35e099d Compare August 16, 2019 21:05
@msau42
Copy link
Contributor

msau42 commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@msau42
Copy link
Contributor

msau42 commented Aug 16, 2019

You're not showing up as an approver?

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 16, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8a0575c into kubernetes-retired:master Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants