Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico: Ability to define global peerings #3493

Merged
merged 1 commit into from Oct 16, 2018
Merged

Calico: Ability to define global peerings #3493

merged 1 commit into from Oct 16, 2018

Conversation

mirwan
Copy link
Contributor

@mirwan mirwan commented Oct 9, 2018

With this, it is possible to define global peers by setting the scope attribute in each peer definition:

peers:
  -router_id: "10.99.0.2"
    as: "65xxx"
    scope: global

When the scope attribute is not set, the BGPPeer resource is considered at node scope and the current behaviour remains

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2018
@mirwan
Copy link
Contributor Author

mirwan commented Oct 9, 2018

cc @rsmitty @bradbeam @mattymo

@mirwan
Copy link
Contributor Author

mirwan commented Oct 9, 2018

ci check this

@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 16, 2018
@mirwan mirwan force-pushed the calico_ability_to_define_global_peerings branch from 7a6497d to 14b2c2f Compare October 16, 2018 07:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@mirwan
Copy link
Contributor Author

mirwan commented Oct 16, 2018

@woopstar I have fixed the conflict. Does it still lgty?

@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bfd4ccb into kubernetes-sigs:master Oct 16, 2018
@mirwan mirwan deleted the calico_ability_to_define_global_peerings branch October 17, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArchiFleKs ArchiFleKs Awaiting requested review from ArchiFleKs

@chapsuk chapsuk Awaiting requested review from chapsuk

Assignees

@woopstar woopstar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mirwan @woopstar @k8s-ci-robot