Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Document our resources schema / yaml #1825

Closed
carolynvs opened this issue Mar 12, 2018 · 9 comments
Closed

Document our resources schema / yaml #1825

carolynvs opened this issue Mar 12, 2018 · 9 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-docs
Milestone

Comments

@carolynvs
Copy link
Contributor

It would be incredibly helpful to have a document that outlines the entire set of acceptable yaml that can be sent to Service Catalog, which fields are required, when you would set an optional value, etc.

For example:

manifest-schema.md

apiVersion: servicecatalog.k8s.io/v1beta1
kind: ServiceInstance
metadata:
  name: ups-instance
  namespace: test-ns
spec:
  clusterServiceClassExternalName: user-provided-service # Required
  clusterServiceClassName: user-provided-service-uuid # Required (but explain that one must be set)
  clusterServicePlanExternalName: default # Required
  clusterServicePlanName: default-uuid #Required (but explain again when)
  parameters: # Optional
    param-1: value-1
    param-2: value-2
...

Maybe a full set to of values and a table explaining each one?

@jeremyrickard
Copy link
Contributor

#dibs

@MHBauer
Copy link
Contributor

MHBauer commented Mar 12, 2018

I feel like the best place for this is types.go, as it is the ultimate source of truth.

Can we generate docs off of the existing comments? Another code-generator to run.

@carolynvs
Copy link
Contributor Author

Another code-generator to run

😝 Yes, I think that's a good idea.

@carolynvs carolynvs added this to the 1.0.0 milestone May 21, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2019
@jberkhahn jberkhahn modified the milestones: 1.0.0, 0.3.0 May 22, 2019
@jberkhahn jberkhahn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2019
@mszostok mszostok removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@mszostok mszostok added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 15, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 12, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-docs
Projects
None yet
Development

No branches or pull requests

7 participants