This repository has been archived by the owner on May 6, 2022. It is now read-only.
Allow updates of instances that failed a previous update. #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
pmorie
reviewed
Oct 31, 2017
| @@ -1426,6 +1426,9 @@ func (c *controller) pollServiceInstance(instance *v1beta1.ServiceInstance) erro | |||
| if deleting { | |||
| toUpdate.Status.DeprovisionStatus = v1beta1.ServiceInstanceDeprovisionStatusSucceeded | |||
| } | |||
| if !deleting { | |||
There was a problem hiding this comment.
The reason that I didn't use else here is that the two branches are not related. It is just coincidental that the conditions are opposites.
| @@ -2020,3 +2023,16 @@ func shouldStartOrphanMitigation(statusCode int) bool { | |||
| statusCode == http.StatusRequestTimeout || | |||
| is5XX | |||
| } | |||
|
|
|||
| // removeServiceInstanceFailedCondition removes the Failed condition from the | |||
There was a problem hiding this comment.
So, when an instance which provisioned but then failed an update is then updated again, we remove the failed condition? maybe we just shouldn't set it when updates fail. WDYT?
k8s-ci-robot
added
size/M
staebler
force-pushed
the
1487-allow_update_after_failed_update
branch
from
b501844
to
1770971
Compare
n3wscott
reviewed
Nov 1, 2017
| @@ -1347,12 +1369,18 @@ func (c *controller) pollServiceInstance(instance *v1beta1.ServiceInstance) erro | |||
| v1beta1.ConditionUnknown, | |||
| errorOrphanMitigationFailedReason, | |||
| "Orphan mitigation failed: "+s) | |||
| } else { | |||
| } else if deleting || provisioning { | |||
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1487.