Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate rule 'namespace:container_cpu_usage_seconds_total:sum_rate' #232

Merged
merged 1 commit into from Aug 7, 2019
Merged

Remove duplicate rule 'namespace:container_cpu_usage_seconds_total:sum_rate' #232

merged 1 commit into from Aug 7, 2019

Conversation

simonpasquier
Copy link
Contributor

Closes #230

@metalmatze
Copy link
Member

Do we even need this with labels? But if so, lgtm.

@brancz
Copy link
Member

brancz commented Aug 7, 2019

label_name was an artifact of Grafana's setup. It should be removed.

@simonpasquier
Copy link
Contributor Author

So the rule should be removed altogether? #230 (comment)

@brancz
Copy link
Member

brancz commented Aug 7, 2019

Just the part about the label_name label. If I recall correctly that will result in a duplicate recording rule, so that should be de-duplicated :)

@simonpasquier
Remove duplicate rule 'namespace:container_cpu_usage_seconds_total:su…
32c7960 
…m_rate'

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier changed the title Fix duplicate rule 'namespace:container_cpu_usage_seconds_total:sum_rate' Remove duplicate rule 'namespace:container_cpu_usage_seconds_total:sum_rate' Aug 7, 2019
@simonpasquier
Copy link
Contributor Author

PR updated to remove the duplicate rule that joined on kube_pod_labels.

@brancz
Copy link
Member

brancz commented Aug 7, 2019

lgtm 👍

@brancz brancz merged commit 167bd42 into kubernetes-monitoring:master Aug 7, 2019
@simonpasquier simonpasquier deleted the fix-230 branch August 7, 2019 15:32
@taizoKaneko taizoKaneko mentioned this pull request Aug 8, 2019
Closed
@lilic lilic mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recording rule generating "duplicate sample for timestamp" errors
3 participants
@simonpasquier @metalmatze @brancz