Fix issues in Compute Resource network panels #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Compute Resource dashboard networking panels to filter by $cluster, like for CPU and Memory panels. This is important when showMultiCluster=true bc the network panels are causing fanout to all clusters, erroneously aggregating across all of them, and may load a quite large number of pods into tables (slow) Rel: kubernetes-monitoring#248
* Fix network panels in the "Compute Resources / Workload" dashboard to respect the selected "$workload" like CPU and memory panels
* Previously, "Compute Resources / Namespace (Workloads)" dashboard was missing a workload "$type" template variable, if there was no datasource called "prometheus" causing a warning to be shown * Template the workload type's datasource as '$datasource' * Fix CPU and memory panels to filter using the type
|
I can file these 3 fixes separately if desired. Note, the "Kubernetes / Networking" dashboards seem to have similar problems, but I've not used or fixed those |
* Add $cluster filter to the "Compute Resources / Workload" network usage table
dghubble
changed the title
|
Nice! |
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Oct 29, 2019
* Add cluster filter to Kubelet dashboard * Add network details in resource dashboards * kubernetes-monitoring/kubernetes-mixin#275 * kubernetes-monitoring/kubernetes-mixin#284 * kubernetes-monitoring/kubernetes-mixin#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$cluster. This is important when showMultiCluster=true, bc the network panels are causing fanout to all clusters, erroneously showing an aggregate across all (CPU and mem do not), and may load many pods in tables (slow)$workloadfilter$datasourceinstead of a hardcoded "prometheus". Also fix CPU and memory panels to filter based on workload typeRelated: #248