alerts: Improve DaemonSet rollout alert taking progress into account #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically we also want to take observed generation into account, but there is currently no metric for this in kube-state-metrics and we'll want to wait a couple of releases after it's released to make use of that metric (see kubernetes/kube-state-metrics#1176).
Once observed generation is available, we can also add:
In the beginning, but this is already much improved. And I'll open an issue after this is merged to track that improvement.
@povilasv @metalmatze @tomwilkie @csmarchbanks
cc @beorn7 @pracucci as you recently improved many of the other apps API alerts