Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerts: Improve DaemonSet rollout alert taking progress into account #476

Merged
merged 2 commits into from Jul 24, 2020

Conversation

brancz
Copy link
Member

@brancz brancz commented Jul 23, 2020

Technically we also want to take observed generation into account, but there is currently no metric for this in kube-state-metrics and we'll want to wait a couple of releases after it's released to make use of that metric (see kubernetes/kube-state-metrics#1176).

Once observed generation is available, we can also add:

kube_daemonset_metadata_generation{%(prefixedNamespaceSelector)s%(kubeStateMetricsSelector)s}                                                                                                                                                                  
  ==
kube_daemonset_status_observed_generation{%(prefixedNamespaceSelector)s%(kubeStateMetricsSelector)s}

In the beginning, but this is already much improved. And I'll open an issue after this is merged to track that improvement.

@povilasv @metalmatze @tomwilkie @csmarchbanks

cc @beorn7 @pracucci as you recently improved many of the other apps API alerts

@beorn7
Copy link
Contributor

beorn7 commented Jul 23, 2020

I'm about to go on vacations and won't be able to have a detailed look in the next two weeks or so. Sorry...

@brancz
Copy link
Member Author

brancz commented Jul 23, 2020

I'm adding some tests and need to adapt the message of the alert as well so moving this to WIP for now.

@brancz brancz changed the title alerts: Improve DaemonSet rollout alert taking progress into account WIP: alerts: Improve DaemonSet rollout alert taking progress into account Jul 23, 2020
@brancz brancz changed the title WIP: alerts: Improve DaemonSet rollout alert taking progress into account alerts: Improve DaemonSet rollout alert taking progress into account Jul 24, 2020
@brancz
Copy link
Member Author

brancz commented Jul 24, 2020

Enjoy your vacation @beorn7!

For the rest, this is now ready for review :)

Copy link
Contributor

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome 🥇

gif

@brancz brancz merged commit 612e6eb into kubernetes-monitoring:master Jul 24, 2020
@brancz brancz deleted the improved-daemonset-alert branch July 24, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants