dashboards/node: Fix Disk Space Usage gauge #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the gauge does not work if there are multiple file systems attached to a node. This fixes it by replacing it with a graph. This also fixes the alignment of the cpu and memory rows. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1622387
|
for brevity, this is how the dashboard looks in f5b2bcf
|
|
and the current regression if multiple file systems are attached to a node:
|
|
and this is how it looks with a multi-filesystem node with this PR: |
|
Makes sense. We should also work towards consolidating the nodes dashboard with the USE/node dashboard. But for now, this fixes the problem at hand. lgtm 👍 |
This was referenced Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the gauge does not work if there are multiple
file systems attached to a node.
This fixes it by replacing it with a graph.
This also fixes the alignment of the cpu and memory rows.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1622387
/cc @brancz @metalmatze