Use kube-scheduler's metrics instead of kube-state-metrics' #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexagod
commented
Jan 10, 2023
6 tasks
paulfantom
requested changes
Jan 31, 2023
There was a problem hiding this comment.
As far as I like this change I can see a problem with this in managed solutions (like EKS) where access to kube-scheduler is forbidden. In those cases alerts and dashboards which are based on kube-scheduler data won't be useful at all. Due to such an issue can we use OR statements instead of deprecating kube-state-metrics data? I think something like kube_pod_resource_request OR kube_pod_container_resource_request should do the trick.
|
Note to self: Revisit this issue once prometheus/prometheus#9624 is implemented. |
|
Just wondering if there's a better (or any) way to format embedded PromQL expressions in |
rexagod
force-pushed
the
mon-2823
branch
2 times, most recently
from
8102d0c
to
eb73d96
Compare
rexagod
changed the title
Use kube-scheduler's metrics instead of kube-state-metrics, as they are more precise. Refer the links below for more details. * https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1748-pod-resource-metrics?rgh-link-date=2022-10-07T13%3A34%3A39Z#expose-new-metrics * kubernetes/kube-state-metrics#1849 Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use kube-scheduler's metrics instead of kube-state-metrics, as they are more precise.
Refer the links below for more details.
Currently I've removed metrics that used the
containerlabel since that is not exposed by the newer metrics. PLMK if we want to take a different approach instead.