Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

asset: set the advertise address based on pod ip #257

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

aaronlevy
Copy link
Contributor

This flag was removed in #151, but looks like we do still need this in some cases.

The bootkube-apiserver was setting the correct endpoint record for the default kubernetes service (kubectl get endpoint/kubernetes). However, after bootkube exits, the self-hosted api-server will eventually overwrite the endpoint again -- and it was using the host's default interface, which is not routable in some cases (e.g. virtualbox).

There may be some other options here (e.g. why does bootkube apiserver use correct interface, but hostNetwork api-server pod does not) -- but going to revert this part of the change so we avoid the regression until we have a better option.

/cc @dghubble @Quentin-M @bassam

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2017
@bassam
Copy link

bassam commented Jan 4, 2017

@aaronlevy this does not fix the problem I'm seeing but might still be necessary due to the virtualbox default interface not being routable.

I made some progress tracking down the issue I'm seeing and it does not happen when I revert #247. I created a new issue for tracking #258

Copy link
Contributor

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely seems to be a larger issue here, but this patch LGTM as a fix for now.

@dghubble
Copy link
Contributor

dghubble commented Jan 4, 2017

This may mean coreos-baremetal needs to use a fork again :(

@aaronlevy
Copy link
Contributor Author

@dghubble there may be other options here - but it is a regression, so need to fix in the short term.

@aaronlevy aaronlevy merged commit b175f42 into kubernetes-retired:master Jan 4, 2017
@aaronlevy aaronlevy deleted the apiaddr branch January 4, 2017 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants