Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

pkg,hack: Update Kubernetes from v1.8.3 to v1.8.4 #780

Merged
merged 1 commit into from Nov 27, 2017
Merged

pkg,hack: Update Kubernetes from v1.8.3 to v1.8.4 #780

merged 1 commit into from Nov 27, 2017

Conversation

dghubble
Copy link
Contributor

@dghubble dghubble commented Nov 20, 2017 •
edited

Conformance tests pass.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2017
@dghubble
Copy link
Contributor Author

coreosbot run e2e

@dghubble
Copy link
Contributor Author

dghubble commented Nov 21, 2017 •
edited

Puzzling. I can run a local cluster (admittedly with Matchbox/QEMU/KVM, maybe not identical) and run the bootkube e2e tests against it successfully. So no local reproduction yet.

Update: Bisecting for possible issues, #781 shows that without #774 and #777 the hyperkube can be bumped without issue. Next up is just eliding one of those at a time.
Update: Well, #781 shows this exact change passing so these seem like flakes.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2017
@dghubble
Copy link
Contributor Author

coreosbot run e2e

aaronlevy
aaronlevy approved these changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@aaronlevy aaronlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dghubble dghubble merged commit e3f8491 into kubernetes-retired:master Nov 27, 2017
@dghubble dghubble deleted the kubernetes-v1.8.4 branch November 27, 2017 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronlevy aaronlevy aaronlevy approved these changes

@diegs diegs Awaiting requested review from diegs

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dghubble @aaronlevy @k8s-ci-robot