This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
go-modules: fix build, module name and local imports #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/M
pablochacin
reviewed
Jun 22, 2019
|
updated OP to include the reason for the rename. |
neolit123
changed the title
chuckha
suggested changes
Jun 24, 2019
- update module to github.com/kubernetes-sigs/cluster-api-provider-docker - modify github.com/chuckha/cluster-api-provider-docker imports to github.com/kubernetes-sigs/cluster-api-provider-docker/kind/actions run 'go mod tidy'
neolit123
force-pushed
the
move-module-imports
branch
from
bb1c2ec
to
d357ca2
Compare
k8s-ci-robot
added
size/S
|
updated to exclude the Delete* rename. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the build in current master:
github.com/kubernetes-sigs/cluster-api-provider-docker/kind/actions
run 'go mod tidy'
the existing functions don't have Cluster in the name:
DeleteControlPlane, DeleteWorker
/kind bug
/priority backlog
/assign @chuckha