This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Remove extra slash from SQ GitHub commit status URL #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
/lgtm |
|
@saad-ali: you can't LGTM a PR unless you are assigned as a reviewer. In response to this comment:
If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
Automatic merge from submit-queue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL currently used by the SQ is subtly wrong: http://submit-queue.k8s.io/#/prs/?prDisplay=39137&historyDisplay=39137 goes to the queue tab. If we remove the slash after "prs", then http://submit-queue.k8s.io/#/prs?prDisplay=39137&historyDisplay=39137 goes to the PR details tab.
cc @saad-ali