This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Configuration flags for cluster autoscaler #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (this *MigConfigFlag) String() string { | ||
| var b bytes.Buffer | ||
| b.WriteString("[") | ||
| for i, npc := range *this { |
There was a problem hiding this comment.
What is npc? Please use more descriptive names.
|
|
||
| type MigConfigFlag []MigConfig | ||
|
|
||
| func (this *MigConfigFlag) String() string { |
There was a problem hiding this comment.
Can we just use combination of fmt.Sprintf and strings.Join? It'll be much more readable.
mwielgus
force-pushed
the
flags
branch
3 times, most recently
from
c43b8d0
to
d258ef0
Compare
| } else { | ||
| return fmt.Errorf("failed to parse mig url: %s", tokens[2]) | ||
| } | ||
| if len(migconfig.Url.String()) < 5 { |
There was a problem hiding this comment.
Please add a comment why 5.
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
Configuration flags for cluster autoscaler
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
Configuration flags for cluster autoscaler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes/kubernetes#24404