This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-Autoscaler - Kubernetes client config builder #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's cc each other on all PRs. It'll be easier to track progress. It probably makes sense to reference our umbrella bug (kubernetes/kubernetes#24404) or other lower priority bugs. @mwielgus Can you please create issues for tasks we've discussed? |
|
+1 to what @fgrzadkowski proposed |
| } | ||
|
|
||
| // GetKubeClientConfig returns rest client configuration based on the passed url. | ||
| func GetKubeClientConfig(uri *url.URL) (*kube_rest.Config, error) { |
|
LGTM |
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…onfig Cluster-Autoscaler - Kubernetes client config builder
mwielgus
pushed a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…onfig Cluster-Autoscaler - Kubernetes client config builder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.