This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Cluster-autoscaler - check generic predicates #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwielgus
force-pushed
the
check-nodes
branch
4 times, most recently
from
eae66b7
to
db37644
Compare
|
|
||
| // CheckPredicates Checks if the given pod can be placed on the given node. | ||
| func (p *PredicateChecker) CheckPredicates(pod *kube_api.Pod, node *kube_api.Node, nodeInfo *schedulercache.NodeInfo) error { | ||
|
|
|
LGTM, please squash commits to have 2: one with godeps, second one with the real changes. |
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…-nodes Cluster-autoscaler - check generic predicates
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…-nodes Cluster-autoscaler - check generic predicates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes/kubernetes#24404
Requires that #866 is merged before.
cc: @piosz @fgrzadkowski