Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Add e2es against local cluster for local volume provisioner #1058

Closed
wants to merge 2 commits into from

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Nov 12, 2018

Fixes #950.

I split PR into two parts:

  • Vendor files in vendor/
  • First version of e2e test for local volume provisioner, you can only review this commit: 5b1c38d

The first version of e2e test is very rudimental but workable, most of code are copied and modified from k8s.io/kubernetes/test/e2e/storage/persistent_volumes-local.go. I will simplify and add more tests in follow up PRs.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: childsb

If they are not already assigned, you can assign the PR to them by writing /assign @childsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 12, 2018
@cofyc cofyc force-pushed the fix950 branch 13 times, most recently from 89ffe57 to a2b2183 Compare November 13, 2018 09:54
- first version of local volume provisioner e2e test suite
@cofyc cofyc changed the title WIP: Add e2es against local cluster Add e2es against local cluster for local volume provisioner Nov 13, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2018
@cofyc
Copy link
Contributor Author

cofyc commented Nov 13, 2018

/assign @msau42

@msau42
Copy link
Contributor

msau42 commented Dec 4, 2018

Did you want to do this here or in the new repo?

@cofyc
Copy link
Contributor Author

cofyc commented Dec 5, 2018

/close
This adds huge dependencies, I'm going to add in the new repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants