This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
Fix non-exponentialbackoff having 0 delay, make it 15s #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
@cofyc fyi |
k8s-ci-robot
added
the
size/XS
|
i'll probably release 4.0.1 and rebuild every provisioner i built for 4.0.0 with this change |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890 so that even if exponentialBackOff is false we retry every ~15s and respect the threshold
W0730 21:07:41.215547 1 controller.go:688] retrying syncing claim "default/nfs-with-bad-class" because failures 5 < threshold 15
W0730 21:07:58.235704 1 controller.go:688] retrying syncing claim "default/nfs-with-bad-class" because failures 6 < threshold 15
W0730 21:08:15.259908 1 controller.go:688] retrying syncing claim "default/nfs-with-bad-class" because failures 7 < threshold 15