Fix log-dir and create path #107

resouer · 2017-03-23T02:48:21Z

I copied flags.go out of vendor because we can only call Hidden before Parse(). So we have to modify flags.go.

k8s-reviewable · 2017-03-23T02:48:26Z

This change is

feiskyer · 2017-03-23T05:28:38Z

pkg/util/flags/flags.go

+
+	path := pflag.Lookup("log-dir").Value.String()
+	if _, err := os.Stat(path); os.IsNotExist(err) {
+		os.Mkdir(path, 644)


should be os.MkdirAll(path, 0755)

feiskyer · 2017-03-23T06:25:27Z

/lgtm

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2017

resouer force-pushed the fix-log branch from c53410d to ebb9cb2 Compare March 23, 2017 02:49

feiskyer self-assigned this Mar 23, 2017

feiskyer reviewed Mar 23, 2017

View reviewed changes

Fix log-dir and create path

1ca46a2

resouer force-pushed the fix-log branch from ebb9cb2 to 1ca46a2 Compare March 23, 2017 05:39

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2017

feiskyer merged commit c4f1ef5 into kubernetes-retired:master Mar 23, 2017

feiskyer mentioned this pull request Mar 23, 2017

Create logs dir automatically if it doesn't exist #97

Closed

resouer deleted the fix-log branch March 23, 2017 06:59

Provide feedback