This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Cni network plugin for frakti #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yao Zengzeng <yaozengzeng@zju.edu.cn>
Signed-off-by: Yao Zengzeng <yaozengzeng@zju.edu.cn>
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
Seems vendor dose not updated properly? @YaoZengzeng |
feiskyer
reviewed
Jan 5, 2017
| return nil, nil, err | ||
| } | ||
|
|
||
| return &Runtime{client: hyperClient, streamingServer: streamingServer, networkPlugin: networkPlugin}, streamingServer, nil |
There was a problem hiding this comment.
nit: lines too long, consider format codes
| const ( | ||
| DefaultInterfaceName = "eth0" | ||
| DefaultNetDir = "/etc/cni/net.d" | ||
| DefaultCNIDir = "/opt/cni/bin" |
There was a problem hiding this comment.
Could we make these two path configurable?
| func InitCNI() (*CNINetworkPlugin, error) { | ||
| plugin := &CNINetworkPlugin{} | ||
|
|
||
| plugin.sandboxNs = make(map[string]*sandboxNetNS) |
There was a problem hiding this comment.
Read and check network config here? So we could fail fast and don't need to read and check again and again later.
| } | ||
|
|
||
| rt := &libcni.RuntimeConf{ | ||
| ContainerID: "cni", |
| } | ||
|
|
||
| for _, link := range links { | ||
| if link.Type() != "veth" { |
There was a problem hiding this comment.
In order to support other interface types, it's better to omit only lo here, e.g. interface name == lo
| } | ||
|
|
||
| type sandboxNetNS struct { | ||
| netns ns.NetNS |
There was a problem hiding this comment.
We need to persist sandbox netns, e.g. in pod labels or write to local files.
| @@ -118,6 +156,11 @@ func (h *Runtime) DeletePodSandbox(podSandboxID string) error { | |||
| return err | |||
| } | |||
|
|
|||
| err = h.networkPlugin.TeardownPodNetwork(podSandboxID) | |||
There was a problem hiding this comment.
network should also be cleared up in StopPodSandbox
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cni network plugin for frakti