Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Add Version 2.14 #146

Merged
merged 3 commits into from
May 26, 2020
Merged

Add Version 2.14 #146

merged 3 commits into from
May 26, 2020

Conversation

edwardecook
Copy link
Contributor

@edwardecook edwardecook commented May 1, 2020

Includes graduating all the previously alpha features.

closes #144

- Graduate previously alpha features
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 1, 2020
@edwardecook
Copy link
Contributor Author

The test coverage loss is primarily due to some methods associated with alpha features not being in use any more, I suppose they could be removed and added back when the next alpha feature is added but that seems somewhat pointless.

@edwardecook
Copy link
Contributor Author

/assign @piotrmiskiewicz

@edwardecook
Copy link
Contributor Author

It would be great to get an update on what is holding this PR back, OSBAPI is approaching releasing a v2.16 (openservicebrokerapi/servicebroker#710) which would put this repo 3 versions out of date.

Copy link

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardecook
Copy link
Contributor Author

Hi @mszostok thanks for the review, I realised there were a bunch of other spots that still erroneously referred to features being ALPHA API only. There are three usages that I haven't touched as part of this PR, one was resolved by #148 and the other two would be resolved by #153.

@edwardecook edwardecook requested a review from mszostok May 26, 2020 11:20
@mszostok
Copy link

thanks for taking care of that 👍
/approve
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edwardecook, mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 26, 2020
@mszostok mszostok merged commit 6c426d2 into kubernetes-retired:master May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for OSBAPI 2.14
4 participants