-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
- Graduate previously alpha features
The test coverage loss is primarily due to some methods associated with alpha features not being in use any more, I suppose they could be removed and added back when the next alpha feature is added but that seems somewhat pointless. |
/assign @piotrmiskiewicz |
It would be great to get an update on what is holding this PR back, OSBAPI is approaching releasing a v2.16 (openservicebrokerapi/servicebroker#710) which would put this repo 3 versions out of date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for taking so long :) Good job 👍
but please also adjust comments so users will know that those methods are not alpha anymore:
thanks for taking care of that 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edwardecook, mszostok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Includes graduating all the previously alpha features.
closes #144