Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Add kube-proxy health check #1004

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Conversation

dvdthms
Copy link
Contributor

@dvdthms dvdthms commented Nov 7, 2017

We had noticed that there wasn't a check for the kube-proxy healthz endpoint in the cfn-signal service.

We hit an issue where the cfn-signal was firing, but the proxy was not healthy (it could not talk to the API-server). We've added this check to make sure the proxy is healthy before allowing the cfn-signal to fire.

Out of interest -- was there a reason this check wasn't included in the command before?

The port used for the kube-proxy healthz can be seen here: https://github.com/kubernetes/kubernetes/blob/v1.7.0/pkg/master/ports/ports.go#L41-L43

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2017
@danielfm
Copy link
Contributor

danielfm commented Nov 7, 2017

This part of the code comes from the early days of kube-aws, it's not a surprise some things may have been overlooked back then.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2017
@codecov-io
Copy link

Codecov Report

Merging #1004 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   34.88%   34.88%           
=======================================
  Files          59       59           
  Lines        4133     4133           
=======================================
  Hits         1442     1442           
  Misses       2532     2532           
  Partials      159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976e946...84d18b4. Read the comment docs.

@mumoshu
Copy link
Contributor

mumoshu commented Nov 9, 2017

was there a reason this check wasn't included in the command before?

No. Thanks for the good catch!

@mumoshu mumoshu added this to the v0.9.9 milestone Nov 9, 2017
@mumoshu mumoshu merged commit 062573d into kubernetes-retired:master Nov 9, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. improvement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants