This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had noticed that there wasn't a check for the kube-proxy healthz endpoint in the cfn-signal service.
We hit an issue where the cfn-signal was firing, but the proxy was not healthy (it could not talk to the API-server). We've added this check to make sure the proxy is healthy before allowing the cfn-signal to fire.
Out of interest -- was there a reason this check wasn't included in the command before?
The port used for the kube-proxy healthz can be seen here: https://github.com/kubernetes/kubernetes/blob/v1.7.0/pkg/master/ports/ports.go#L41-L43