This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Add some additional cleanup to rkt containers #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
=======================================
Coverage 34.88% 34.88%
=======================================
Files 59 59
Lines 4133 4133
=======================================
Hits 1442 1442
Misses 2532 2532
Partials 159 159Continue to review full report at Codecov.
|
|
/lgtm |
|
@dvdthms Thanks for your contribution as always! |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…kt-container-cleanup Add some additional cleanup to rkt containers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the services that use rkt containers had a command to perform some cleanup.
I've added the corresponding command to a service that was missing it, and also added some additional syntax to pre-existing commands in order to keep them consistent.