-
Notifications
You must be signed in to change notification settings - Fork 295
Fix the render command to not wipe ca.pem #1014
Conversation
4983e6a
to
473ecd4
Compare
Squashed a fix for an easy mistake. Please reload to see the latest commit id if anyone has already seen it. |
f54e61a
to
b2ad675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this probably works. I'm not so clear on what we're generating now as it's significantly changed but we don't have much documentation on it, could we add some?
name string | ||
data []byte | ||
overwrite bool | ||
ifEmptySymlinkTo string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean if populated, create a symlink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - If we had nothing to write, default to create a symlink to denoted by the ifEmptySymlinkTo
.
Basically, we have nothing to write for worker-ca.pem
as long as the user explicitly overwrite or put the file before running kube-aws render credentials
. So in that case, create a symlink to ca.pem
(=the same as the previous behavior).
Squashed again. Seems to work so far. |
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 34.88% 34.86% -0.03%
==========================================
Files 59 59
Lines 4133 4156 +23
==========================================
+ Hits 1442 1449 +7
- Misses 2532 2545 +13
- Partials 159 162 +3
Continue to review full report at Codecov.
|
b2ad675
to
76e1341
Compare
I've manually verified this to work by running
However, this issue is not yet resolved in kube-aws - see #1013 for more info. |
I'll merge this once someone put LGTM on it |
/lgtm 😃 |
…a-pem Fix the render command to not wipe ca.pem
Fixes #1003
@c-knowles Would this work for you?