Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Correct values for the kubernetes.io/cluster/<Cluster ID> tags #1067

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Correct values for the kubernetes.io/cluster/<Cluster ID> tags #1067

merged 1 commit into from
Dec 8, 2017

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Dec 8, 2017

Resolves #1025

@mumoshu mumoshu added this to the v0.9.9 milestone Dec 8, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2017
@mumoshu
Copy link
Contributor Author

mumoshu commented Dec 8, 2017

See my comment at #1025 (comment) for why I'm fixing this now.

@codecov-io
Copy link

Codecov Report

Merging #1067 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1067   +/-   ##
=======================================
  Coverage   35.13%   35.13%           
=======================================
  Files          59       59           
  Lines        3393     3393           
=======================================
  Hits         1192     1192           
  Misses       2039     2039           
  Partials      162      162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1113eb0...62d0209. Read the comment docs.

@mumoshu
Copy link
Contributor Author

mumoshu commented Dec 8, 2017

Merging this as I've already tested this while experimenting on #1058

@mumoshu mumoshu merged commit e2fb8d4 into kubernetes-retired:master Dec 8, 2017
@mumoshu mumoshu deleted the correct-cluster-id-tag-values branch December 8, 2017 10:06
@mumoshu
Copy link
Contributor Author

mumoshu commented Dec 8, 2017

Sonobuoy Scan Result: https://scanner.heptio.com/6b16bb7c0e7f460375ac2f2cd95f2c52/diagnostics/

@mumoshu mumoshu added the kind/bug Categorizes issue or PR as related to a bug. label Dec 8, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
@mumoshu
Merge pull request kubernetes-retired#1067 from mumoshu/correct-clust…
1e0afdc 
…er-id-tag-values

Correct values for the `kubernetes.io/cluster/<Cluster ID>` tags
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mumoshu @codecov-io @k8s-ci-robot