This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Allow toggling Metrics Server installation #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
mumoshu
changed the title
mumoshu
force-pushed
the
toggle-metrics-server
branch
2 times, most recently
from
e7a641b
to
6ac795b
Compare
k8s-ci-robot
added
size/M
mumoshu
force-pushed
the
toggle-metrics-server
branch
from
6ac795b
to
d9fe738
Compare
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
=======================================
Coverage 35.13% 35.13%
=======================================
Files 59 59
Lines 3393 3393
=======================================
Hits 1192 1192
Misses 2039 2039
Partials 162 162Continue to review full report at Codecov.
|
|
Manually verified this to work by updating my cluster toggling metrics-server several times. |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…s-server Allow toggling Metrics Server installation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1054