This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
fix: kube-aws update success message formatting issue
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 63.74% (diff: 100%)@@ master #117 diff @@
==========================================
Files 4 4
Lines 924 924
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 589 589
Misses 254 254
Partials 81 81
|
Output from `kube-aws update` contained an errant `%!(EXTRA` due to a missing formatting placeholder. Fixes kubernetes-retired#116
mefellows
force-pushed
the
fix/issue-116
branch
from
c0cf618
to
33bd31b
Compare
|
@mefellows Thanks for the good catch 😄 👍 |
|
No worries - hopefully this is the start of some... meatier... contributions :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output from
kube-aws updatecontained an errant%!(EXTRAdue to a missing formatting placeholder.
Fixes #116