Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix node registration issue for spot-fleet-powered worker nodes #141

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Dec 8, 2016

This change fixes the issue that the second and the subsequent nodes in each spot fleet couldn't be registered thus unable to run any pods.

ref #112 (comment)

@codecov-io
Copy link

codecov-io commented Dec 8, 2016

Current coverage is 69.90% (diff: 100%)

Merging #141 into master will not change coverage

@@             master       #141   diff @@
==========================================
  Files             5          5          
  Lines          1110       1110          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            776        776          
  Misses          249        249          
  Partials         85         85          

Powered by Codecov. Last update 3870415...a4e5d25

@mumoshu mumoshu changed the title Fix node registration issues for spot-fleet-powered worker nodes Fix node registration issue for spot-fleet-powered worker nodes Dec 8, 2016
@mumoshu
Copy link
Contributor Author

mumoshu commented Dec 8, 2016

I've confirmed that node registration just work with the following process:

  • Create a main cluster
  • Create 2 node pools, each with targetCapacity=3 thus 2 nodes
    • only 1 of 2 nodes is registered
  • Apply the change from this PR and create a node pool with targetCapacity=3 thus 2 nodes
    • 2 of 2 nodes is registered, as expected
NAME                                              STATUS                     AGE
ip-10-0-0-164.ap-northeast-1.compute.internal     Ready                      5h
ip-10-0-0-197.ap-northeast-1.compute.internal     Ready,SchedulingDisabled   7h
ip-10-0-0-202.ap-northeast-1.compute.internal     Ready                      7h
ip-10-0-101-46.ap-northeast-1.compute.internal    Ready                      1h <---from node pool 1 (without fix)
ip-10-0-102-64.ap-northeast-1.compute.internal    Ready                      1h <---from node pool 2 (without fix)
ip-10-0-103-197.ap-northeast-1.compute.internal   Ready                      1h <---from node pool 3 (with fix)
ip-10-0-103-232.ap-northeast-1.compute.internal   Ready                      1h <---from node pool 3 (with fix)

--volume=dns,kind=host,source=/etc/resolv.conf,readOnly=true --mount volume=dns,target=/etc/resolv.conf \
--net=host \
--trust-keys-from-https \
--insecure-options=ondisk \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--insecure-options=ondisk to skip verification on docker images on the disk.
The verification is IMHO not needed for us as we don't verify when running images using docker.
Skipping verification results in faster container startup.

@mumoshu mumoshu added this to the v0.9.2-rc.4 milestone Dec 8, 2016
@mumoshu mumoshu merged commit 56f08d5 into kubernetes-retired:master Dec 8, 2016
@mumoshu mumoshu deleted the fix-node-registration-for-spot-fleet-powered-workers branch December 8, 2016 08:57
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
…tration-for-spot-fleet-powered-workers

Fix node registration issue for spot-fleet-powered worker nodes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants