Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Bug/fix cf stack paging v0.12.x #1482

Merged

Conversation

cknowles
Copy link
Contributor

@cknowles cknowles commented Nov 6, 2018

No description provided.

Rather than ListStacks without any paging.

Fixes kubernetes-retired#1479
Fix up tests to use the newly used DescribeStacks
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: c-knowles

If they are not already assigned, you can assign the PR to them by writing /assign @c-knowles in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2018
@cknowles cknowles requested review from mumoshu and removed request for mumoshu and redbaron November 6, 2018 08:44
@cknowles cknowles changed the title Bug/fix cf stack paging v0.12 Bug/fix cf stack paging v0.12.x Nov 6, 2018
@codecov-io
Copy link

Codecov Report

Merging #1482 into v0.12.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.12.x    #1482      +/-   ##
===========================================
+ Coverage    37.91%   37.92%   +0.01%     
===========================================
  Files           75       75              
  Lines         4595     4596       +1     
===========================================
+ Hits          1742     1743       +1     
  Misses        2611     2611              
  Partials       242      242
Impacted Files Coverage Δ
cfnstack/cfnstack.go 85.96% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e327d...1212f67. Read the comment docs.

@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2018
@cknowles
Copy link
Contributor Author

cknowles commented Nov 8, 2018

@mumoshu merge and release a patch for this? Were there any other patches so far relevant for 0.12.x?

@mumoshu
Copy link
Contributor

mumoshu commented Nov 8, 2018

@c-knowles I'm considering to merge #1484 as well before cutting v0.12.1.

Edit: Fixed wrong verion num in my prev comment

@mumoshu mumoshu merged commit c996f36 into kubernetes-retired:v0.12.x Nov 9, 2018
@mumoshu
Copy link
Contributor

mumoshu commented Nov 9, 2018

@c-knowles Thanks for the fix!

@mumoshu mumoshu added this to the v0.12.1 milestone Nov 9, 2018
@cknowles cknowles deleted the bug/fix-cf-stack-paging-v0.12 branch December 5, 2018 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants