Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Minor fixes in documentation #1505

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

PabloCastellano
Copy link
Contributor

  • Add missing backslash to multi-line command
  • Reorder kube-aws commands in README to match Quick Start
  • Newline end of file

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2018
* Add missing backslash to multi-line command
* Reorder kube-aws commands in README to match Quick Start
* Newline end of file
@PabloCastellano
Copy link
Contributor Author

CLA signed and changed email to match my CNCF's

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 30, 2018
@codecov-io
Copy link

Codecov Report

Merging #1505 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
  Coverage   25.47%   25.47%           
=======================================
  Files          97       97           
  Lines        5001     5001           
=======================================
  Hits         1274     1274           
  Misses       3580     3580           
  Partials      147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc29af4...1de00db. Read the comment docs.

Copy link
Contributor

@cknowles cknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c-knowles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@cknowles
Copy link
Contributor

cknowles commented Dec 7, 2018

@PabloCastellano thank you for your contribution!

@k8s-ci-robot k8s-ci-robot merged commit c2c175a into kubernetes-retired:master Dec 7, 2018
@PabloCastellano PabloCastellano deleted the docs_minor branch December 8, 2018 11:55
@davidmccormick davidmccormick added this to the v0.13.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants