Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix for using StrictName to define a specific Controller Role Name #1516

Merged

Conversation

davidmccormick
Copy link
Contributor

Correction/Bug - the IAMRoleController should always be a reference to the cloudformation role object unless it is managed externally, not just because we have used a strict name.

…o the cloudformation role object unless it is managed externally, not just because we have used a strict name.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mumoshu

If they are not already assigned, you can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2018
@codecov-io
Copy link

Codecov Report

Merging #1516 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1516   +/-   ##
=======================================
  Coverage   25.46%   25.46%           
=======================================
  Files          97       97           
  Lines        5003     5003           
=======================================
  Hits         1274     1274           
  Misses       3582     3582           
  Partials      147      147
Impacted Files Coverage Δ
pkg/api/controller.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62da15...0f78b04. Read the comment docs.

@davidmccormick davidmccormick merged commit d4530f1 into kubernetes-retired:master Dec 18, 2018
davidmccormick added a commit to HotelsDotCom/kube-aws that referenced this pull request Dec 18, 2018
…o the cloudformation role object unless it is managed externally, not just because we have used a strict name. (kubernetes-retired#1516)
@davidmccormick davidmccormick deleted the correct-strict-name branch January 2, 2019 11:32
@mumoshu mumoshu added this to the v0.13.0 milestone Jan 9, 2019
kevtaylor pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Jan 9, 2019
…o the cloudformation role object unless it is managed externally, not just because we have used a strict name. (kubernetes-retired#1516)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants