Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix for kubelet startup on nodes when using TLS bootstrapping #1522

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Fix for kubelet startup on nodes when using TLS bootstrapping #1522

merged 2 commits into from
Jan 9, 2019

Conversation

davidmccormick
Copy link
Contributor

Always write a kubeconfig file - even when using the TLS bootstrapping feature
Failure to specify a kubeconfig file will result in a failed startup and cryptic "file not found" error message on the kubelet.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: redbaron

If they are not already assigned, you can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

codecov-io commented Jan 2, 2019 •
edited

Codecov Report

Merging #1522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1522   +/-   ##
=======================================
  Coverage   25.46%   25.46%           
=======================================
  Files          97       97           
  Lines        5003     5003           
=======================================
  Hits         1274     1274           
  Misses       3582     3582           
  Partials      147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b7380...8a25475. Read the comment docs.

@davidmccormick davidmccormick mentioned this pull request Jan 2, 2019
Merged
mumoshu
mumoshu approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix ☺️

@mumoshu mumoshu merged commit 88287d6 into kubernetes-retired:master Jan 9, 2019
@mumoshu mumoshu added this to the v0.13.0 milestone Jan 9, 2019
kevtaylor pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Jan 9, 2019
@davidmccormick
Fix for kubelet startup on nodes when using TLS bootstrapping (kubern…
61fbf16 
…etes-retired#1522)

* ALWAYS write a kubeconfig file - even when using the TLS bootstrapping feature

* TLS worker pem symlink is always created so use it always in the kubeconfig
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@danielfm danielfm Awaiting requested review from danielfm

@redbaron redbaron Awaiting requested review from redbaron

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidmccormick @k8s-ci-robot @codecov-io @mumoshu