Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Adding the ability to set arbitrary feature gates to controller components #1541

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

omar-nahhas
Copy link
Contributor

@omar-nahhas omar-nahhas commented Jan 17, 2019

Currently, kube-aws support the ability to add arbitrary feature gates to the kubelet on the worker nodes, although those feature gates flags are not propagated to the kubelets running on the controller nor the other controller components (.i.e. apiserver, scheduler and controller manager). This PR aims to bring consistency and extend the functionality of setting feature gates to those components.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mumoshu

If they are not already assigned, you can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2019
@omar-nahhas omar-nahhas changed the title Kube aws pr Adding the ability to add set arbitrary feature gates to controller components Jan 17, 2019
@omar-nahhas omar-nahhas changed the title Adding the ability to add set arbitrary feature gates to controller components Adding the ability to set arbitrary feature gates to controller components Jan 17, 2019
@omar-nahhas
Copy link
Contributor Author

/assign @davidmccormick

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #1541 into master will increase coverage by 0.02%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1541      +/-   ##
==========================================
+ Coverage   25.45%   25.47%   +0.02%     
==========================================
  Files          97       97              
  Lines        5005     5016      +11     
==========================================
+ Hits         1274     1278       +4     
- Misses       3584     3591       +7     
  Partials      147      147
Impacted Files Coverage Δ
pkg/api/cluster.go 0% <0%> (ø) ⬆️
pkg/model/node_pool_config.go 34.88% <100%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7a13e...97d1fd1. Read the comment docs.

@davidmccormick
Copy link
Contributor

Sorry @omar-nahhas, I noticed that the tests use enabled and disabled as values for configuring the feature gates. Please could you change it to either "true" or "false" so that the value corresponds to the command line argument expected by kubernetes (which uses the boolean values)? Otherwise, looks good and looking forward to this change! :)

Ensure PodPriority is disabled when specified on the config
@davidmccormick davidmccormick merged commit 6b64cf6 into kubernetes-retired:master Jan 18, 2019
@davidmccormick davidmccormick added this to the v0.13.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants