-
Notifications
You must be signed in to change notification settings - Fork 295
Adding the ability to set arbitrary feature gates to controller components #1541
Adding the ability to set arbitrary feature gates to controller components #1541
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @davidmccormick |
30e48e4
to
8d8896e
Compare
8d8896e
to
b45a6e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
+ Coverage 25.45% 25.47% +0.02%
==========================================
Files 97 97
Lines 5005 5016 +11
==========================================
+ Hits 1274 1278 +4
- Misses 3584 3591 +7
Partials 147 147
Continue to review full report at Codecov.
|
Sorry @omar-nahhas, I noticed that the tests use |
Ensure PodPriority is disabled when specified on the config
b45a6e7
to
97d1fd1
Compare
Currently, kube-aws support the ability to add arbitrary feature gates to the kubelet on the worker nodes, although those feature gates flags are not propagated to the kubelets running on the controller nor the other controller components (.i.e. apiserver, scheduler and controller manager). This PR aims to bring consistency and extend the functionality of setting feature gates to those components.