Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fixing adding cf resources to etcd and networking stack - master #1553

Merged

Conversation

omar-nahhas
Copy link
Contributor

Based on the existing test, it seems that the intent was that etcd and networking stacks both could benefit from the cloud formation resources included in the plugins. Unfortunately, there was a bug in the template (in the case of etcd) and missing logic in the case of the networking stack that prevented it from happening.

  • Enable plugin cf resources for networking stack
  • Fixing etcd template to add plugin cf resources

- Enable plugin cf resources for networking stack
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: danielfm

If they are not already assigned, you can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2019
@omar-nahhas
Copy link
Contributor Author

/assign @davidmccormick

@codecov-io
Copy link

Codecov Report

Merging #1553 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
- Coverage   25.47%   25.46%   -0.02%     
==========================================
  Files          97       97              
  Lines        5016     5019       +3     
==========================================
  Hits         1278     1278              
- Misses       3591     3594       +3     
  Partials      147      147
Impacted Files Coverage Δ
pkg/api/plugin.go 0% <ø> (ø) ⬆️
pkg/model/stack_new.go 32.29% <0%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b64cf6...1bb543a. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.13.0 milestone Feb 11, 2019
@davidmccormick davidmccormick merged commit 6fe5658 into kubernetes-retired:master Feb 13, 2019
@davidmccormick
Copy link
Contributor

Thanks very much for your contribution! 🙏

@omar-nahhas
Copy link
Contributor Author

omar-nahhas commented Feb 13, 2019

Manually tested, an upgrade from 0.12 to 0.13 (with plugins migration), including a plugin that put some cf code (a Prometheus asg) inside the network stack.

test_13

test_2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants