Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Make cluster-autoscaler resource request/limit configurable #1557

Conversation

Luke-Humphreys
Copy link
Contributor

What

We've exposed the cluster-autoscaler deployment resources and made them configurable via cluster.yaml using the same approach taken regarding the kube-dashboard

Why

We've started to experience OOM issues & CPU throttling in our bigger environments.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2019
@Luke-Humphreys
Copy link
Contributor Author

/assign @davidmccormick

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: danielfm

If they are not already assigned, you can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2019
@codecov-io
Copy link

Codecov Report

Merging #1557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1557   +/-   ##
======================================
  Coverage    25.8%   25.8%           
======================================
  Files          98      98           
  Lines        5057    5057           
======================================
  Hits         1305    1305           
  Misses       3605    3605           
  Partials      147     147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe5658...8f9d4b4. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.13.0 milestone Feb 14, 2019
@davidmccormick davidmccormick merged commit 12e66c5 into kubernetes-retired:master Feb 14, 2019
@davidmccormick
Copy link
Contributor

Many thanks Luke! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants