Capture failures in decrypting assets #1571
Conversation
"set -e" will capture when a line of code fails. However, for a pipeline such as "false | true", it will only handle the exit code of the last command. In this case, the exit code will always be 0. "set -o pipefail" will ensure that any failure in the pipeline results in the whole line failing, which will then be handled correctly by "set -e" For example: $ set +o pipefail ; false | true ; echo $? 0 $ set -o pipefail ; false | true ; echo $? 1
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
|
/assign @mumoshu |
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
======================================
Coverage 25.8% 25.8%
======================================
Files 98 98
Lines 5057 5057
======================================
Hits 1305 1305
Misses 3605 3605
Partials 147 147Continue to review full report at Codecov.
|
|
/lgtm |
|
/lgtm |
|
Thanks @sgolightly for this useful patch! |
"set -e" will capture when a line of code fails. However, for a
pipeline such as "false | true", it will only handle the exit code
of the last command. In this case, the exit code will always be 0.
"set -o pipefail" will ensure that any failure in the pipeline results
in the whole line failing, which will then be handled correctly by
"set -e"
For example:
$ set +o pipefail ; false | true ; echo $?
0
$ set -o pipefail ; false | true ; echo $?
1