Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Allow plugins to add CFN tags and outputs #1575

Conversation

Luke-Humphreys
Copy link
Contributor

What

Adding the ability for plugins to inject cloud formation tags into control plane and node pool stacks.
Adding the ability for plugins to inject output cloud formation into control plane, node pool, etcd and network stacks.

Why

In the process of developing a plugin for the cluster-autoscaler I noticed that you can only inject resources into cloud formation stacks from plugins, this meant I couldn't add the necessary ASG tags for the cluster-autoscaler. The functionality was already there, I just extended it a little bit.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2019
@Luke-Humphreys
Copy link
Contributor Author

/assign @redbaron

@Luke-Humphreys
Copy link
Contributor Author

/assign @davidmccormick

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: redbaron

If they are not already assigned, you can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1575 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
+ Coverage    25.8%   25.81%   +<.01%     
==========================================
  Files          98       98              
  Lines        5057     5063       +6     
==========================================
+ Hits         1305     1307       +2     
- Misses       3605     3609       +4     
  Partials      147      147
Impacted Files Coverage Δ
pkg/model/types.go 66.66% <ø> (ø) ⬆️
pkg/api/plugin.go 0% <ø> (ø) ⬆️
pkg/model/stack_new.go 32.33% <33.33%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f14e23...2b6a595. Read the comment docs.

@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@davidmccormick davidmccormick merged commit 1b146a4 into kubernetes-retired:master Apr 8, 2019
@davidmccormick
Copy link
Contributor

Thanks @Luke-Humphreys for this useful expansion of our plugin functionality! 🙏

@davidmccormick davidmccormick added this to the v0.13.0 milestone Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants