Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Enable detailed monitoring #1585

Merged
merged 3 commits into from
May 2, 2019
Merged

Enable detailed monitoring #1585

merged 3 commits into from
May 2, 2019

Conversation

paalkr
Copy link
Contributor

@paalkr paalkr commented May 1, 2019

Launch Templates introduced in #1531 did not enable monitoring. This PR adds detailed monitoring, so that worker nodes will behave the same way they did prior to kube-aws 0.13

paalkr and others added 3 commits April 10, 2019 17:26
Removed LaunchTemplateName
Enabled detailed monitoring for the LaunchTemplate
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: redbaron

If they are not already assigned, you can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 1, 2019
@codecov-io
Copy link

Codecov Report

Merging #1585 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1585   +/-   ##
=======================================
  Coverage   25.86%   25.86%           
=======================================
  Files          98       98           
  Lines        5068     5068           
=======================================
  Hits         1311     1311           
  Misses       3610     3610           
  Partials      147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de82a15...1d587e5. Read the comment docs.

@paalkr
Copy link
Contributor Author

paalkr commented May 1, 2019

/assign @davidmccormick

@davidmccormick davidmccormick added this to the v0.13.0 milestone May 2, 2019
@davidmccormick davidmccormick merged commit 04c9aa5 into kubernetes-retired:master May 2, 2019
@davidmccormick
Copy link
Contributor

Many thanks for your contribution! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants