Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Custom APIServer SANs #1586

Merged
merged 1 commit into from
May 2, 2019
Merged

Custom APIServer SANs #1586

merged 1 commit into from
May 2, 2019

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Adds the ability to define custom SANs to the APIServer. Internally we found this incredibly useful when trying to roll changes to CIDRs inside of the cluster.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: c-knowles

If they are not already assigned, you can assign the PR to them by writing /assign @c-knowles in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #1586 into master will increase coverage by 0.04%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
+ Coverage   25.86%   25.91%   +0.04%     
==========================================
  Files          98       98              
  Lines        5068     5067       -1     
==========================================
+ Hits         1311     1313       +2     
+ Misses       3610     3607       -3     
  Partials      147      147
Impacted Files Coverage Δ
pkg/api/cluster.go 0% <ø> (ø) ⬆️
credential/generator.go 0% <0%> (ø) ⬆️
pkg/model/credentials.go 61.76% <100%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c9aa5...3c7cfe1. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.13.0 milestone May 2, 2019
@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@davidmccormick davidmccormick merged commit 55e2a6e into kubernetes-retired:master May 2, 2019
@davidmccormick
Copy link
Contributor

Thanks, this looks useful! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants