Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

NAT Gateway tagging #1063 #1596

Merged
merged 1 commit into from
May 21, 2019

Conversation

vsamidurai
Copy link
Contributor

@vsamidurai vsamidurai commented May 19, 2019

adding cloud formation template NAT Gateway tags #1063

@k8s-ci-robot
Copy link
Contributor

Welcome @vsamidurai!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: danielfm

If they are not already assigned, you can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 19, 2019
@vsamidurai
Copy link
Contributor Author

/assign @danielfm

@codecov-io
Copy link

Codecov Report

Merging #1596 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1596   +/-   ##
=======================================
  Coverage   25.67%   25.67%           
=======================================
  Files          98       98           
  Lines        5052     5052           
=======================================
  Hits         1297     1297           
  Misses       3610     3610           
  Partials      145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2ecb6...cc12c3d. Read the comment docs.

@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2019
@davidmccormick davidmccormick merged commit 23cbcfe into kubernetes-retired:master May 21, 2019
@davidmccormick
Copy link
Contributor

Hi @vsamidurai! Many thanks for this contribution! 🙏

davidmccormick pushed a commit to HotelsDotCom/kube-aws that referenced this pull request May 22, 2019
@davidmccormick davidmccormick added this to the v0.13.0-rc.2 milestone May 22, 2019
@vsamidurai vsamidurai mentioned this pull request Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants