Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Conversation

davidmccormick
Copy link
Contributor

Subnets in the controller stack not being referenced against the network stack when being managed by kube-aws. Map subnets back to the looked up set by name. Various additional log messages to debug level. Remove some helper functions on tempCtx types by calling the correct path in the stack templates.

…ork stack when being managed by kube-aws. Map subnets back to the looked up set by name. Various additional log messages to debug level. Remove some helper functions on tempCtx types by calling the correct path in the stack templates.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: danielfm

If they are not already assigned, you can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidmccormick
Copy link
Contributor Author

Hopefully resolves #1595 which looks like it might be a long standing issue from the Netowork stack refactor.

@codecov-io
Copy link

Codecov Report

Merging #1598 into master will decrease coverage by 0.17%.
The diff coverage is 36.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
- Coverage   25.67%   25.49%   -0.18%     
==========================================
  Files          98       97       -1     
  Lines        5052     5060       +8     
==========================================
- Hits         1297     1290       -7     
- Misses       3610     3625      +15     
  Partials      145      145
Impacted Files Coverage Δ
pkg/api/subnet.go 1.36% <0%> (-0.03%) ⬇️
pkg/api/subnets.go 18.42% <0%> (-4.92%) ⬇️
filereader/texttemplate/texttemplate.go 5.71% <0%> (-0.09%) ⬇️
pkg/model/stack.go 31.53% <50%> (-3.58%) ⬇️
pkg/model/stack_new.go 33.68% <66.66%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2ecb6...f72db49. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.13.0 milestone May 21, 2019
@davidmccormick davidmccormick merged commit 2a7b776 into kubernetes-retired:master May 22, 2019
@davidmccormick davidmccormick modified the milestones: v0.13.0, v0.13.0-rc.2 May 22, 2019
davidmccormick added a commit to HotelsDotCom/kube-aws that referenced this pull request May 22, 2019
…ork stack when being managed by kube-aws. Map subnets back to the looked up set by name. Various additional log messages to debug level. Remove some helper functions on tempCtx types by calling the correct path in the stack templates. (kubernetes-retired#1598)
@koen92 koen92 mentioned this pull request Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants