-
Notifications
You must be signed in to change notification settings - Fork 295
Allow setting Kiam version <3.0 #1599
Allow setting Kiam version <3.0 #1599
Conversation
@paalkr does the PR aid your cluster migration strategy? |
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 97 97
Lines 5060 5060
=======================================
Hits 1290 1290
Misses 3625 3625
Partials 145 145
Continue to review full report at Codecov.
|
Slightly out of scope of this PR, but should we also update the image version of kiam in the cluster.yaml.tmpl? It's still set to a default of 2.8. |
/lgtm |
I think it's a good idea to let users decide which versions of kiam they would like to run, and it's definitely a good move to support backwards compatibility. When it comes to upgrade of kiam to 3.2, users have to update their kiam certs at some point. But this pr will probably make migration to 0.13 a little easier for many users, as there is just one thing less to focus on. The kiam upgrade can be carried out later, after the main cluster upgrade. Personally I will probably make the move to kiam 3.2 during the initial cluster upgrade, as I have tested the cert update and documented in our systems how to execute the upgrade. |
7eade94
to
7dd9b86
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7dd9b86
to
d207c4d
Compare
Updated cluster.yaml template as suggested and updated the default values so that it caches lookups by having a default session timeout of 30m and changing the server urls to remove the :port shenanigans. |
d207c4d
to
a26f650
Compare
Update Kiam template and defaults. Change default sessontimeout to 30m by default so that Kiam does some caching. Update tests with 30m session caching
a26f650
to
c7c2a65
Compare
Update Kiam template and defaults. Change default sessontimeout to 30m by default so that Kiam does some caching. Update tests with 30m session caching
The Kiam server and agent command line flags changed in v3.0.
Although we install Kiam v3.2 by default - allow users to deploy older versions with the different command line options.
Tested deploying v2.7 and then upgrading to v3.2