Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Reserve resources for calico typha #1607

Merged

Conversation

zonzamas
Copy link
Contributor

Calico-typha does not have any reserved resource so it works in a best effort mode. Since it is a 'system service' it should have some resources reserved. What do you think?

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 28, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2019
@davidmccormick
Copy link
Contributor

Good idea! In which case they should be configurable via the cluster.yaml so that users can increase them if the defaults prove too small. Can you add them in as options?

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #1607 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
- Coverage   25.49%   25.41%   -0.08%     
==========================================
  Files          98       98              
  Lines        5049     5064      +15     
==========================================
  Hits         1287     1287              
- Misses       3619     3634      +15     
  Partials      143      143
Impacted Files Coverage Δ
pkg/api/cluster.go 0% <0%> (ø) ⬆️
filereader/texttemplate/texttemplate.go 5.33% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44211cb...7a3e476. Read the comment docs.

@dominicgunn
Copy link
Contributor

Any chance you could sign the CLA and address David's comments @zonzamas?

@zonzamas
Copy link
Contributor Author

Hi, Im have it sing already with the other email I used to use to contribute to kube-aws. I will definitely revisit this when I have some free time or when I need it for my current company.

@zonzamas
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dominicgunn
Copy link
Contributor

Thanks @zonzamas, I'd still like to see this be configurable through cluster.yaml before merging. Could you take a look at doing that?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2019
@zonzamas
Copy link
Contributor Author

zonzamas commented Jul 1, 2019

Sure, how about this?

Copy link
Contributor

@davidmccormick davidmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would you be able to make the small change I requested?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2019
@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019
@davidmccormick davidmccormick self-requested a review July 2, 2019 14:33
@davidmccormick davidmccormick merged commit 48e5de2 into kubernetes-retired:master Jul 2, 2019
@davidmccormick
Copy link
Contributor

Hi, many thanks - would you be so kind as to cherry-pick this change and PR to our v0.13.x branch and v0.14.x branch? That way your change will go out with those upcoming updates rather than when v0.15.x is released. Thanks for your contribution! 🙏

zonzamas added a commit to zonzamas/kube-aws that referenced this pull request Jul 3, 2019
* Reserve resources for calico typha

* Parametrize typha computing resources

* Defaults typha resources in new cluster fuction
zonzamas added a commit to zonzamas/kube-aws that referenced this pull request Jul 3, 2019
* Reserve resources for calico typha

* Parametrize typha computing resources

* Defaults typha resources in new cluster fuction
davidmccormick pushed a commit that referenced this pull request Jul 3, 2019
* Reserve resources for calico typha

* Parametrize typha computing resources

* Defaults typha resources in new cluster fuction
davidmccormick pushed a commit that referenced this pull request Jul 3, 2019
* Reserve resources for calico typha

* Parametrize typha computing resources

* Defaults typha resources in new cluster fuction
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants