Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.13.x] Configurable CoreDNS TTL #1625

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Allows a configurable TTL for CoreDNS.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign c-knowles
You can assign the PR to them by writing /assign @c-knowles in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2019
@dominicgunn dominicgunn changed the title Configurable CoreDNS TTL [v0.13.x] Configurable CoreDNS TTL Jun 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #1625 into v0.13.x will decrease coverage by 0.33%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.13.x    #1625      +/-   ##
===========================================
- Coverage    25.54%   25.21%   -0.34%     
===========================================
  Files           98       98              
  Lines         5038     5426     +388     
===========================================
+ Hits          1287     1368      +81     
- Misses        3608     3910     +302     
- Partials       143      148       +5
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/cluster.go 0% <0%> (ø) ⬆️
pkg/model/stack_new.go 30.41% <0%> (-3.45%) ⬇️
pkg/api/controller.go 0% <0%> (ø) ⬆️
pkg/api/worker_node_pool.go 15.06% <0%> (+2.67%) ⬆️
pkg/model/node_pool_compile.go 64.35% <0%> (+5.14%) ⬆️
credential/store.go 48% <0%> (+5.89%) ⬆️
pkg/api/etcd.go 39.43% <0%> (+8.11%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8a556...b8a493f. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.13.0-rc.3 milestone Jun 17, 2019
@davidmccormick davidmccormick merged commit 77177a7 into v0.13.x Jun 17, 2019
@davidmccormick
Copy link
Contributor

Great, many thanks - looks good!

@mumoshu mumoshu deleted the v0.13.x-core-dns-ttl branch June 20, 2019 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants