-
Notifications
You must be signed in to change notification settings - Fork 295
Etcd version #1646
Etcd version #1646
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 98 98
Lines 5049 5049
=======================================
Hits 1287 1287
Misses 3619 3619
Partials 143 143 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for looking at it! 😀👍🏻
Would you be able to cherry-pick this fix and PR for the v0.13.x and v0.14.x branch for me? |
I can try, but I'm not a git expert. Will it be sufficient to create PRs in the 0.13.x and 0.14.x branches? |
Nice eyes guys, thanks for spotting this @paalkr. |
Hi, no problem, I can do it tomorrow! :)
… On 27 Jun 2019, at 09:05, Pål Kristensen ***@***.***> wrote:
I can try, but I'm not a git expert. Will it be sufficient to create PRs in the 0.13.x and 0.14.x branches?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Many thanks for your contribution! 🙏 |
* Update etcdadm * Update cluster.yaml.tmpl
* Update etcdadm * Update cluster.yaml.tmpl
0.13.x Etcd version (#1646)
0.14.x Etcd version (#1646)
Change how etcd versions are specified, to resemble etcd project releases.