Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Etcd version #1646

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Etcd version #1646

merged 2 commits into from
Jun 28, 2019

Conversation

paalkr
Copy link
Contributor

@paalkr paalkr commented Jun 27, 2019

Change how etcd versions are specified, to resemble etcd project releases.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mumoshu
You can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #1646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1646   +/-   ##
=======================================
  Coverage   25.49%   25.49%           
=======================================
  Files          98       98           
  Lines        5049     5049           
=======================================
  Hits         1287     1287           
  Misses       3619     3619           
  Partials      143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e0f19...23bc88e. Read the comment docs.

Copy link
Contributor

@davidmccormick davidmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for looking at it! 😀👍🏻

@davidmccormick
Copy link
Contributor

Would you be able to cherry-pick this fix and PR for the v0.13.x and v0.14.x branch for me?

@paalkr
Copy link
Contributor Author

paalkr commented Jun 27, 2019

I can try, but I'm not a git expert. Will it be sufficient to create PRs in the 0.13.x and 0.14.x branches?

@dominicgunn
Copy link
Contributor

Nice eyes guys, thanks for spotting this @paalkr.

@davidmccormick
Copy link
Contributor

davidmccormick commented Jun 27, 2019 via email

@davidmccormick
Copy link
Contributor

Many thanks for your contribution! 🙏

@davidmccormick davidmccormick merged commit 44211cb into kubernetes-retired:master Jun 28, 2019
davidmccormick pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Jun 28, 2019
* Update etcdadm

* Update cluster.yaml.tmpl
davidmccormick pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Jun 28, 2019
* Update etcdadm

* Update cluster.yaml.tmpl
k8s-ci-robot added a commit that referenced this pull request Jun 28, 2019
k8s-ci-robot added a commit that referenced this pull request Jun 28, 2019
@paalkr paalkr deleted the etcd-version branch August 10, 2019 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants