Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Etcd cannot depend on resources in another stack #1667

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Etcd cannot depend on resources in another stack #1667

merged 1 commit into from
Jul 4, 2019

Conversation

koen92
Copy link
Contributor

@koen92 koen92 commented Jul 3, 2019

The dependency on the other stack gives errors. Starting the etcd node
before the natgateway is deployed is not a big issue as it keeps
restarting its proces to fetch its data. Wait signal should be long
enough for this to be resolved.

Fixes #1332

@koen92
Cannot depend on resources in another stack
a59e353 
The dependency on the other stack gives errors. Starting the etcd node
before the natgateway is deployed is not a big issue as it keeps
restarting its proces to fetch its data. Wait signal should be long
enough for this to be resolved.

Fixes kubernetes-retired#1332
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #1667 into v0.13.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.13.x    #1667   +/-   ##
========================================
  Coverage    25.46%   25.46%           
========================================
  Files           98       98           
  Lines         5054     5054           
========================================
  Hits          1287     1287           
  Misses        3624     3624           
  Partials       143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbaaf8...a59e353. Read the comment docs.

@davidmccormick
Copy link
Contributor

Thanks @koen92 this looks great - could you cherry pick this to v0.14.x and master please?

This was referenced Jul 3, 2019
Merged
Merged
@koen92
Copy link
Contributor Author

koen92 commented Jul 3, 2019

Thanks @koen92 this looks great - could you cherry pick this to v0.14.x and master please?

Thank you for your reaction, I cherry picked them see:

@davidmccormick davidmccormick merged commit a5d440d into kubernetes-retired:v0.13.x Jul 4, 2019
@davidmccormick
Copy link
Contributor

Thanks very much for your contribution! 🙏

@davidmccormick davidmccormick added this to the v0.13.0-rc.3 milestone Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cknowles cknowles Awaiting requested review from cknowles

@mumoshu mumoshu Awaiting requested review from mumoshu

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@koen92 @k8s-ci-robot @codecov-io @davidmccormick