This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Conform worker nodes powered by spot fleets to the ones powered by autoscaling groups #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.36% (diff: 100%)@@ master #167 diff @@
==========================================
Files 4 4
Lines 1126 1126
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 781 781
Misses 259 259
Partials 86 86
|
7 tasks
mumoshu
force-pushed
the
conform-spot-fleet-to-asg
branch
from
1376282
to
c44d17e
Compare
… spot fleet to conform these nodes to the ones powered by a autoscaling group ref kubernetes-retired#112 see also http://docs.aws.amazon.com/cli/latest/reference/ec2/create-tags.html and http://stackoverflow.com/a/1250279 for implementation details
mumoshu
force-pushed
the
conform-spot-fleet-to-asg
branch
from
c44d17e
to
2d480a3
Compare
mumoshu
force-pushed
the
conform-spot-fleet-to-asg
branch
from
2d480a3
to
c61b0c5
Compare
|
From now on, both ASG-based and SpotFleet-based worker nodes can be added to an ELB load balancer with experimental:
loadBalancer:
names: [ "name-of-lb" ]
|
|
Also from now on, both ASG-based and SpotFleet-based worker nodes can be tagged with
|
|
Updated E2E test suite to cover deployments to existing VPCs 🎉 |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…leet-to-asg Conform worker nodes powered by spot fleets to the ones powered by autoscaling groups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last two TODOs mentioned in #112 are addressed