Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.13.x] - Allow an AntiAffinty tolerant to help ensure even spread of DNS pods #1672

Merged
merged 4 commits into from
Jul 9, 2019
Merged

[v0.13.x] - Allow an AntiAffinty tolerant to help ensure even spread of DNS pods #1672

merged 4 commits into from
Jul 9, 2019

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Adds a preferred scheduling anti-affinity to try and target nodes in different AZs if enabled.

Useful in situations where we have autoscaling enabled or are deploying DNS pods to nodes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2019
@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #1672 into v0.13.x will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.13.x   #1672      +/-   ##
==========================================
- Coverage    25.41%   25.4%   -0.01%     
==========================================
  Files           98      98              
  Lines         5064    5065       +1     
==========================================
  Hits          1287    1287              
- Misses        3634    3635       +1     
  Partials       143     143
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/cluster.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d440d...125101f. Read the comment docs.

Copy link
Contributor

@davidmccormick davidmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@davidmccormick davidmccormick added this to the v0.13.0-rc.3 milestone Jul 8, 2019
@davidmccormick davidmccormick merged commit e5a2165 into kubernetes-retired:v0.13.x Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants