Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Move kube2iam to a plugin #1730

Merged

Conversation

davidmccormick
Copy link
Contributor

Move kube2iam out of the core codebase and into its own plugin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2019
@davidmccormick davidmccormick added this to the v0.15.0 milestone Sep 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #1730 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
+ Coverage   25.19%   25.21%   +0.02%     
==========================================
  Files          98       98              
  Lines        5017     5013       -4     
==========================================
  Hits         1264     1264              
+ Misses       3611     3607       -4     
  Partials      142      142
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/cluster.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c55fb...3bc633d. Read the comment docs.

@davidmccormick
Copy link
Contributor Author

@dominicgunn could you take a quick look? I've spun it up in a new cluster to test and looks ok.

Copy link
Contributor

@dominicgunn dominicgunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, also love the idea of moving all of this to a plugin.

@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2019
@davidmccormick davidmccormick merged commit 78f7799 into kubernetes-retired:master Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants