Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Migrate the kubernetes dashboard to a plugin and plugin templating improvements. #1754

Merged

Conversation

davidmccormick
Copy link
Contributor

@davidmccormick davidmccormick commented Oct 9, 2019

With optional ingress object and secrets creation.
With autoscaling based on cluster size/nodes.
Upgrade dashboard to kubernetesui/dashboard:v2.0.0-beta4

Templating system improvements: -
Allow use of templating in pki keypairs common names, orgs and dnsNames.
Allow use of templating in any string within a plugins values section.
Fix bugs scanning files for AWS CloudFormation Tags.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #1754 into master will decrease coverage by 0.04%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
- Coverage   25.15%   25.11%   -0.05%     
==========================================
  Files          98       98              
  Lines        5024     5033       +9     
==========================================
  Hits         1264     1264              
- Misses       3618     3627       +9     
  Partials      142      142
Impacted Files Coverage Δ
pkg/api/plugin_config.go 0% <0%> (ø) ⬆️
tmpl/text_to_cfn_expr.go 86.66% <100%> (ø) ⬆️
pkg/model/stack_new.go 34.21% <25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad1cc1...8e67e2e. Read the comment docs.

@davidmccormick davidmccormick changed the title Migrate the kubernetes dashboard to a plugin. Migrate the kubernetes dashboard to a plugin and plugin templating improvements. Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2019
With optional ingress object and secrets creation.
With proportional cluster autoscaling.
Upgrade dashboard to kubernetesui/dashboard:v2.0.0-beta4

Templating system improvements: -
Allow use of templating in keypairs common names, orgs and dnsNames.
Allow use of templating in plugins values sections.
Fix bugs scanning files for AWS CloudFormation Tags.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2019
Copy link
Contributor

@jorge07 jorge07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@davidmccormick davidmccormick merged commit f6e3933 into kubernetes-retired:master Oct 16, 2019
@davidmccormick davidmccormick added this to the v0.15.0 milestone Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants